Prechádzať zdrojové kódy

Minor - Improve function performance. Avoid calling unused code.

jmontoyaa 7 rokov pred
rodič
commit
0068a7cda9

+ 1 - 1
main/inc/lib/internationalization.lib.php

@@ -424,7 +424,6 @@ function api_get_utc_datetime(
     $returnNullIfInvalidDate = false,
     $returnObj = false
 ) {
-    $fromTimezone = api_get_timezone();
     if (is_null($time) || empty($time) || $time === '0000-00-00 00:00:00') {
         if ($returnNullIfInvalidDate) {
             return null;
@@ -443,6 +442,7 @@ function api_get_utc_datetime(
         return gmdate('Y-m-d H:i:s', $time);
     }
     try {
+        $fromTimezone = api_get_timezone();
         $date = new DateTime($time, new DateTimezone($fromTimezone));
         $date->setTimezone(new DateTimeZone('UTC'));
         if ($returnObj) {

+ 11 - 8
main/inc/lib/tracking.lib.php

@@ -7391,10 +7391,13 @@ class TrackingCourseLog
             }
         }
 
-        while ($user = Database::fetch_array($res, 'ASSOC')) {
-            $courseInfo = api_get_course_info($course_code);
-            $courseId = $courseInfo['real_id'];
+        $courseInfo = api_get_course_info($course_code);
+        $courseId = $courseInfo['real_id'];
+
+        $urlBase = api_get_path(WEB_CODE_PATH).'mySpace/myStudents.php?details=true&cidReq='.$course_code.
+            '&course='.$course_code.'&origin=tracking_course&id_session='.$session_id;
 
+        while ($user = Database::fetch_array($res, 'ASSOC')) {
             $user['official_code'] = $user['col0'];
             $user['username'] = $user['col3'];
 
@@ -7475,11 +7478,11 @@ class TrackingCourseLog
                 $user['survey'] = (isset($survey_user_list[$user['user_id']]) ? $survey_user_list[$user['user_id']] : 0).' / '.$total_surveys;
             }
 
-            $user['link'] = '<center>
-                             <a href="../mySpace/myStudents.php?student='.$user['user_id'].'&details=true&course='.$course_code.'&origin=tracking_course&id_session='.$session_id.'">
-                             '.Display::return_icon('2rightarrow.png', get_lang('Details')).'
-                             </a>
-                         </center>';
+            $url = $urlBase.'&student='.$user['user_id'];
+
+            $user['link'] = '<center><a href="'.$url.'">
+                            '.Display::return_icon('2rightarrow.png', get_lang('Details')).'
+                             </a></center>';
 
             // store columns in array $users
             $is_western_name_order = api_is_western_name_order();