Browse Source

Replace id with aria-label

Ids were added to link inputs with text label. As they are dangerous
(very common english word) and they are only useful for accessibility,
replace them by aria-label
Polycapa 7 years ago
parent
commit
1691cf3eee
3 changed files with 5 additions and 5 deletions
  1. 1 1
      main/admin/course_add.php
  2. 3 3
      main/admin/settings.lib.php
  3. 1 1
      main/inc/lib/sessionmanager.lib.php

+ 1 - 1
main/admin/course_add.php

@@ -47,7 +47,7 @@ $form->addText(
     get_lang('Title'),
     true,
     array(
-        'id' => 'title'
+        'aria-label' => get_lang('Title')
     )
 );
 $form->applyFilter('title', 'html_filter');

+ 3 - 3
main/admin/settings.lib.php

@@ -1327,7 +1327,7 @@ function generateSettingsForm($settings, $settings_by_access_list)
                             get_lang($row['comment']),
                             get_lang('MB')
                         ),
-                        array('maxlength' => '8', 'id' => $row['variable'])
+                        array('maxlength' => '8', 'aria-label' => get_lang($row['title']))
                     );
                     $form->applyFilter($row['variable'], 'html_filter');
                     $default_values[$row['variable']] = round($row['selected_value']/1024/1024, 1);
@@ -1339,7 +1339,7 @@ function generateSettingsForm($settings, $settings_by_access_list)
                             get_lang($row['title']),
                             get_lang($row['comment']),
                         ),
-                        array('maxlength' => '5', 'id' => $row['variable'])
+                        array('maxlength' => '5', 'aria-label' => get_lang($row['title']))
                     );
                     $form->applyFilter($row['variable'], 'html_filter');
                     $default_values[$row['variable']] = $row['selected_value'];
@@ -1349,7 +1349,7 @@ function generateSettingsForm($settings, $settings_by_access_list)
                     continue;
                 } else {
                     $hideme['class'] = 'col-md-4';
-                    $hideme['id'] = $row['variable'];
+                    $hideme['aria-label'] = get_lang($row['title']);
                     $form->addElement(
                         'text',
                         $row['variable'],

+ 1 - 1
main/inc/lib/sessionmanager.lib.php

@@ -7131,7 +7131,7 @@ class SessionManager
             'name',
             get_lang('SessionName'),
             true,
-            ['maxlength' => 150, 'id' => 'name']
+            ['maxlength' => 150, 'aria-label' => get_lang('SessionName')]
         );
         $form->addRule('name', get_lang('SessionNameAlreadyExists'), 'callback', 'check_session_name');