Browse Source

Minor - fix php warning

Julio 5 years ago
parent
commit
1807e56e5b

+ 2 - 1
main/gradebook/lib/be/evaluation.class.php

@@ -644,8 +644,9 @@ class Evaluation implements GradebookItem
                 }
                 $students[$res->get_user_id()] = $score;
             }
+
             if (empty($count)) {
-                return null;
+                return [null, null];
             }
 
             switch ($type) {

+ 6 - 2
main/gradebook/lib/flatview_data_generator.class.php

@@ -730,7 +730,11 @@ class FlatViewDataGenerator
             }
 
             if (!empty($model)) {
-                $temp_score = $temp_score.' '.ExerciseLib::show_score($score[0], $score[1]);
+                $scoreToShow = '';
+                if (isset($score[0]) && isset($score[1])) {
+                    $scoreToShow = ExerciseLib::show_score($score[0], $score[1]);
+                }
+                $temp_score = $temp_score.' '.$scoreToShow;
             }
 
             if (!isset($this->params['only_total_category']) ||
@@ -963,7 +967,7 @@ class FlatViewDataGenerator
                 for ($count = 0; $count < count($this->evals_links); $count++) {
                     $item = $this->evals_links[$count];
                     $score = $item->calc_score($user[0]);
-                    $divide = ($score[1]) == 0 ? 1 : $score[1];
+                    $divide = $score[1] == 0 ? 1 : $score[1];
                     $item_value += $score[0] / $divide * $item->get_weight();
                     $item_total += $item->get_weight();
                     $score_denom = ($score[1] == 0) ? 1 : $score[1];