Browse Source

Fix double calendar event creation see BT#13723

Julio 7 years ago
parent
commit
2ca5df06b6
1 changed files with 4 additions and 4 deletions
  1. 4 4
      main/cron/import_csv.php

+ 4 - 4
main/cron/import_csv.php

@@ -1239,7 +1239,7 @@ class ImportCsv
                     if (empty($eventInfo)) {
                         // Means that agenda external id exists but the event doesn't exist
                         $this->logger->addInfo("external event id exists: $externalEventId");
-                        $this->logger->addInfo("but Chamilo event don't exists: ".$item['item_id']);
+                        $this->logger->addInfo("but Chamilo event doesn't exists: ".$item['item_id']);
 
                         $eventId = $agenda->addEvent(
                             $event['start'],
@@ -1258,19 +1258,19 @@ class ImportCsv
 
                         if (!empty($eventId)) {
                             $this->logger->addInfo("Chamilo event created: ".$eventId);
-                            $values = $extraFieldValue->get_values_by_handler_and_field_id(
+                            $extraFieldValueItem = $extraFieldValue->get_values_by_handler_and_field_id(
                                 $item['item_id'],
                                 $extraFieldInfo['id']
                             );
 
-                            foreach ($values as $extraFieldValueItem) {
+                            if (!empty($extraFieldValueItem) && isset($extraFieldValueItem['id'])) {
                                 $params = [
                                     'id' => $extraFieldValueItem['id'],
                                     'item_id' => $eventId
                                 ];
                                 $extraFieldValue->update($params);
                                 $this->logger->addInfo(
-                                    'Updating calendar extra field  #'.$extraFieldValueItem['id'].' new item_id: '.$eventId.' old item_id: '.$item['item_id']
+                                    'Updating calendar extra field #'.$extraFieldValueItem['id'].' new item_id: '.$eventId.' old item_id: '.$item['item_id']
                                 );
                             }
                         } else {