Browse Source

Cleaning code

Julio Montoya 15 years ago
parent
commit
46b3f46fb0
1 changed files with 90 additions and 192 deletions
  1. 90 192
      main/newscorm/lp_add_item.php

+ 90 - 192
main/newscorm/lp_add_item.php

@@ -1,28 +1,8 @@
-<?php // $Id: index.php 16620 2008-10-25 20:03:54Z yannoo $
-/*
-==============================================================================
-	Dokeos - elearning and course management software
-
-	Copyright (c) 2004-2008 Dokeos SPRL
-	Copyright (c) 2003 Ghent University (UGent)
-
-	For a full list of contributors, see "credits.txt".
-	The full license can be read in "license.txt".
-
-	This program is free software; you can redistribute it and/or
-	modify it under the terms of the GNU General Public License
-	as published by the Free Software Foundation; either version 2
-	of the License, or (at your option) any later version.
-
-	See the GNU General Public License for more details.
-
-	Contact: Dokeos, rue Notre Dame, 152, B-1140 Evere, Belgium, info@dokeos.com
-==============================================================================
-*/
+<?php
+/* For licensing terms, see /license.txt */
 
 
 /**
-==============================================================================
 * This is a learning path creation and player tool in Dokeos - previously
 * learnpath_handler.php
 *
@@ -31,23 +11,17 @@
 * @author Roan Embrechts, refactoring and code cleaning
 * @author Yannick Warnier <ywarnier@beeznest.org> - cleaning and update
 * @author Julio Montoya  - Improving the list of templates
-* @package dokeos.learnpath
-==============================================================================
+* @package chamilo.learnpath
 */
 
 /*
-==============================================================================
 		INIT SECTION
-==============================================================================
 */
 $this_section=SECTION_COURSES;
 
 api_protect_course_script();
-
 /*
------------------------------------------------------------
 	Libraries
------------------------------------------------------------
 */
 //the main_api.lib.php, database.lib.php and display.lib.php
 //libraries are included by default
@@ -57,12 +31,10 @@ include('learnpath_functions.inc.php');
 include('resourcelinker.inc.php');
 //rewrite the language file, sadly overwritten by resourcelinker.inc.php
 // name of the language file that needs to be included
-$language_file = "learnpath";
+$language_file = 'learnpath';
 
 /*
------------------------------------------------------------
 	Header and action code
------------------------------------------------------------
 */
 $htmlHeadXtra[] = '
 <script type="text/javascript">
@@ -72,15 +44,13 @@ var temp2=false;
 var use_document_title='.api_get_setting('use_document_title').';
 var load_default_template = '. ((isset($_POST['submit']) || empty($_SERVER['QUERY_STRING'])) ? 'false' : 'true' ) .';
 
-function FCKeditor_OnComplete( editorInstance )
-{
+function FCKeditor_OnComplete( editorInstance ) {
 	editorInstance.Events.AttachEvent( \'OnSelectionChange\', check_for_title ) ;
 	document.getElementById(\'frmModel\').innerHTML = "<iframe height=890px width=230px; frameborder=0 src=\''.api_get_path(WEB_LIBRARY_PATH).'fckeditor/editor/fckdialogframe.html \'>";
 }
 
-function check_for_title()
-	{
-		if(temp==true){
+function check_for_title() {
+		if (temp==true) {
 			// This functions shows that you can interact directly with the editor area
 			// DOM. In this way you have the freedom to do anything you want with it.
 
@@ -133,15 +103,11 @@ function check_for_title()
 		temp=true;
 	}
 
-function InnerDialogLoaded()
-{
-	if (document.all)
-	{
+function InnerDialogLoaded() {
+	if (document.all) {
 		// if is iexplorer
 		var B=new window.frames.content_lp___Frame.FCKToolbarButton(\'Templates\',window.content_lp___Frame.FCKLang.Templates);
-	}
-	else
-	{
+	} else {
 		var B=new window.frames[0].FCKToolbarButton(\'Templates\',window.frames[0].FCKLang.Templates);
 	}
 
@@ -152,9 +118,7 @@ function InnerDialogLoaded()
 
 $htmlHeadXtra[] = $_SESSION['oLP']->create_js();
 /*
------------------------------------------------------------
 	Constants and variables
------------------------------------------------------------
 */ 
 
 $is_allowed_to_edit = api_is_allowed_to_edit(null,true);
@@ -180,19 +144,16 @@ $prereq         = $_REQUEST['prereq'];
 $type           = $_REQUEST['type'];
 */
 /*
-==============================================================================
 		MAIN CODE
-==============================================================================
 */
 // using the resource linker as a tool for adding resources to the learning path
-if ($action=="add" and $type=="learnpathitem")
-{
+if ($action=="add" and $type=="learnpathitem") {
 	 $htmlHeadXtra[] = "<script language='JavaScript' type='text/javascript'> window.location=\"../resourcelinker/resourcelinker.php?source_id=5&action=$action&learnpath_id=$learnpath_id&chapter_id=$chapter_id&originalresource=no\"; </script>";
 }
-if ( (! $is_allowed_to_edit) or ($isStudentView) )
-{
+if ( (! $is_allowed_to_edit) or ($isStudentView) ) {
 	error_log('New LP - User not authorized in lp_add_item.php');
 	header('location:lp_controller.php?action=view&lp_id='.$learnpath_id);
+	exit;
 }
 //from here on, we are admin because of the previous condition, so don't check anymore
 
@@ -202,14 +163,12 @@ $therow=Database::fetch_array($result);
 
 //$admin_output = '';
 /*
------------------------------------------------------------
 	Course admin section
 	- all the functions not available for students - always available in this case (page only shown to admin)
------------------------------------------------------------
 */
-/*==================================================
+/*
 			SHOWING THE ADMIN TOOLS
- ==================================================*/
+ */
 if (isset($_SESSION['gradebook'])){
 	$gradebook=	$_SESSION['gradebook'];
 }
@@ -224,7 +183,7 @@ if (!empty($gradebook) && $gradebook=='view') {
 $interbreadcrumb[]= array ("url"=>"lp_controller.php?action=list", "name"=> get_lang("_learning_path"));
 $interbreadcrumb[]= array ("url"=>api_get_self()."?action=build&lp_id=$learnpath_id", "name" => stripslashes("{$therow['name']}"));
 
-switch($_GET['type']){
+switch($_GET['type']) {
 	case 'chapter':
 		$interbreadcrumb[]= array ("url"=>"#", "name" => get_lang("NewChapter"));
 	break;
@@ -270,19 +229,14 @@ function confirmation(name)
 //echo $admin_output;
 
 /*
------------------------------------------------------------
 	DISPLAY SECTION
------------------------------------------------------------
 */
 echo $_SESSION['oLP']->build_action_menu();
 echo '<table cellpadding="0" cellspacing="0" class="lp_build">';
-
 	echo '<tr>';
-
 		echo '<td class="tree">';
 			// show the template list
-			if (isset($_GET['type']) && $_GET['type']=='document' && !isset($_GET['file']))
-			{
+			if (isset($_GET['type']) && $_GET['type']=='document' && !isset($_GET['file'])) {
 				$count_items = count($_SESSION['oLP']->ordered_items);
 				$style = ($count_items > 12)?' style="height:250px;width:230px;overflow-x : auto; overflow-y : scroll;" ':' class="lp_tree" ';
 				echo '<div  '.$style.'>';
@@ -300,146 +254,90 @@ echo '<table cellpadding="0" cellspacing="0" class="lp_build">';
 				echo '</div>';
 			}
 
-
 		echo '</td>';
 		echo '<td class="workspace">';
 
-			if(isset($new_item_id) && is_numeric($new_item_id))
-			{
-				switch($_GET['type'])
-				{
-
-					case 'chapter':
-						echo $_SESSION['oLP']->display_manipulate($new_item_id, $_GET['type']);
-						Display::display_confirmation_message(get_lang('NewChapterCreated'));
-						break;
-
-					case TOOL_LINK:
-						echo $_SESSION['oLP']->display_manipulate($new_item_id, $_GET['type']);
-						Display::display_confirmation_message(get_lang('NewLinksCreated'));
-						break;
-
-					case TOOL_STUDENTPUBLICATION:
-
-						echo $_SESSION['oLP']->display_manipulate($new_item_id, $_GET['type']);
-						Display::display_confirmation_message(get_lang('NewStudentPublicationCreated'));
-						break;
-
-					case 'module':
-
-						echo $_SESSION['oLP']->display_manipulate($new_item_id, $_GET['type']);
-						Display::display_confirmation_message(get_lang('NewModuleCreated'));
-						break;
-
-					case TOOL_QUIZ:
-
-						echo $_SESSION['oLP']->display_manipulate($new_item_id, $_GET['type']);
-						Display::display_confirmation_message(get_lang('NewExerciseCreated'));
-						break;
-
-
-					case TOOL_DOCUMENT:
-						Display::display_confirmation_message(get_lang('NewDocumentCreated'));
-						echo $_SESSION['oLP']->display_item($new_item_id, true, $msg);
-						break;
-
-
-					case TOOL_FORUM:
-						echo $_SESSION['oLP']->display_manipulate($new_item_id, $_GET['type']);
-						Display::display_confirmation_message(get_lang('NewForumCreated'));
-						break;
-
-
-					case 'thread':
-						echo $_SESSION['oLP']->display_manipulate($new_item_id, $_GET['type']);
-						Display::display_confirmation_message(get_lang('NewThreadCreated'));
-						break;
-
-				}
+		if(isset($new_item_id) && is_numeric($new_item_id)) {
+			switch($_GET['type']) {
+				case 'chapter':
+					echo $_SESSION['oLP']->display_manipulate($new_item_id, $_GET['type']);
+					Display::display_confirmation_message(get_lang('NewChapterCreated'));
+					break;
+				case TOOL_LINK:
+					echo $_SESSION['oLP']->display_manipulate($new_item_id, $_GET['type']);
+					Display::display_confirmation_message(get_lang('NewLinksCreated'));
+					break;
+				case TOOL_STUDENTPUBLICATION:
+					echo $_SESSION['oLP']->display_manipulate($new_item_id, $_GET['type']);
+					Display::display_confirmation_message(get_lang('NewStudentPublicationCreated'));
+					break;
+				case 'module':
+					echo $_SESSION['oLP']->display_manipulate($new_item_id, $_GET['type']);
+					Display::display_confirmation_message(get_lang('NewModuleCreated'));
+					break;
+				case TOOL_QUIZ:
+
+					echo $_SESSION['oLP']->display_manipulate($new_item_id, $_GET['type']);
+					Display::display_confirmation_message(get_lang('NewExerciseCreated'));
+					break;
+
+				case TOOL_DOCUMENT:
+					Display::display_confirmation_message(get_lang('NewDocumentCreated'));
+					echo $_SESSION['oLP']->display_item($new_item_id, true, $msg);
+					break;
+				case TOOL_FORUM:
+					echo $_SESSION['oLP']->display_manipulate($new_item_id, $_GET['type']);
+					Display::display_confirmation_message(get_lang('NewForumCreated'));
+					break;
+				case 'thread':
+					echo $_SESSION['oLP']->display_manipulate($new_item_id, $_GET['type']);
+					Display::display_confirmation_message(get_lang('NewThreadCreated'));
+					break;
 			}
-			else
-			{
-				switch($_GET['type'])
-				{
-					case 'chapter':
-
-						echo $_SESSION['oLP']->display_item_form($_GET['type'], get_lang("EnterDataNewChapter"));
-
-						break;
-
-					case 'module':
-
-						echo $_SESSION['oLP']->display_item_form($_GET['type'], get_lang("EnterDataNewModule"));
-
-						break;
-
-					case 'document':
-
-						if(isset($_GET['file']) && is_numeric($_GET['file']))
-						{
-							echo $_SESSION['oLP']->display_document_form('add', 0, $_GET['file']);
-						}
-						else
-						{
-							echo $_SESSION['oLP']->display_document_form('add', 0);
-						}
-
-						break;
-
-					case 'hotpotatoes':
-
-						echo $_SESSION['oLP']->display_hotpotatoes_form('add', 0, $_GET['file']);
-
-						break;
-
-					case 'quiz':
-
-						echo $_SESSION['oLP']->display_quiz_form('add', 0, $_GET['file']);
-
-						break;
-
-					case 'forum':
-
-						echo $_SESSION['oLP']->display_forum_form('add', 0, $_GET['forum_id']);
-
-						break;
-
-					case 'thread':
-
-						echo $_SESSION['oLP']->display_thread_form('add', 0, $_GET['thread_id']);
-
-						break;
-
-					case 'link':
-
-						echo $_SESSION['oLP']->display_link_form('add', 0, $_GET['file']);
-
-						break;
-
-					case 'student_publication':
-
-						echo $_SESSION['oLP']->display_student_publication_form('add', 0, $_GET['file']);
-
-						break;
-
-					case 'step':
-
-						echo $_SESSION['oLP']->display_resources();
-
-						break;
-				}
+		} else {
+			switch($_GET['type']) {
+				case 'chapter':
+					echo $_SESSION['oLP']->display_item_form($_GET['type'], get_lang("EnterDataNewChapter"));
+					break;
+				case 'module':
+					echo $_SESSION['oLP']->display_item_form($_GET['type'], get_lang("EnterDataNewModule"));
+					break;
+				case 'document':
+					if(isset($_GET['file']) && is_numeric($_GET['file'])) {
+						echo $_SESSION['oLP']->display_document_form('add', 0, $_GET['file']);
+					} else {
+						echo $_SESSION['oLP']->display_document_form('add', 0);
+					}
+					break;
+				case 'hotpotatoes':
+					echo $_SESSION['oLP']->display_hotpotatoes_form('add', 0, $_GET['file']);
+					break;
+				case 'quiz':
+					echo $_SESSION['oLP']->display_quiz_form('add', 0, $_GET['file']);
+					break;
+				case 'forum':
+					echo $_SESSION['oLP']->display_forum_form('add', 0, $_GET['forum_id']);
+					break;
+				case 'thread':
+					echo $_SESSION['oLP']->display_thread_form('add', 0, $_GET['thread_id']);
+					break;
+				case 'link':
+					echo $_SESSION['oLP']->display_link_form('add', 0, $_GET['file']);
+					break;
+				case 'student_publication':
+					echo $_SESSION['oLP']->display_student_publication_form('add', 0, $_GET['file']);
+					break;
+				case 'step':
+					echo $_SESSION['oLP']->display_resources();
+					break;
 			}
-
+		}
 		echo '</td>';
-
 	echo '</tr>';
-
 echo '</table>';
 
 /*
-==============================================================================
 		FOOTER
-==============================================================================
 */
 Display::display_footer();
 ?>