Browse Source

Minor - fix php warning, int casting

Julio 6 years ago
parent
commit
4cea149cb1

+ 1 - 1
main/exercise/question_pool.php

@@ -815,7 +815,7 @@ if (is_array($mainQuestionList)) {
             $answerType,
             $session_id,
             $question['exerciseId'],
-                $objExercise
+            $objExercise
         ).' '.
         get_action_icon_for_question(
             $actionIcon2,

+ 1 - 1
main/inc/lib/AnnouncementManager.php

@@ -1337,7 +1337,7 @@ class AnnouncementManager
     public static function get_attachment($announcementId)
     {
         $table = Database::get_course_table(TABLE_ANNOUNCEMENT_ATTACHMENT);
-        $announcementId = intval($announcementId);
+        $announcementId = (int) $announcementId;
         $courseId = api_get_course_int_id();
         $row = [];
         $sql = 'SELECT id, path, filename, comment 

+ 2 - 2
main/inc/lib/course.lib.php

@@ -5779,8 +5779,8 @@ class CourseManager
      */
     public static function getFirstCourseAccessPerSessionAndUser($sessionId, $userId)
     {
-        $sessionId = intval($sessionId);
-        $userId = intval($userId);
+        $sessionId = (int) $sessionId;
+        $userId = (int) $userId;
 
         $table = Database::get_main_table(TABLE_STATISTIC_TRACK_E_COURSE_ACCESS);
         $sql = "SELECT * FROM $table

+ 1 - 1
main/inc/lib/document.lib.php

@@ -498,7 +498,7 @@ class DocumentManager
      */
     public static function getSessionFolderFilters($path, $sessionId)
     {
-        $sessionId = intval($sessionId);
+        $sessionId = (int) $sessionId;
         $condition = null;
 
         if (!empty($sessionId)) {

+ 1 - 1
main/inc/lib/extra_field.lib.php

@@ -1964,7 +1964,7 @@ class ExtraField extends Model
         $form = new FormValidator($this->type.'_field', 'post', $url);
 
         $form->addElement('hidden', 'type', $this->type);
-        $id = isset($_GET['id']) ? intval($_GET['id']) : null;
+        $id = isset($_GET['id']) ? (int) $_GET['id'] : null;
         $form->addElement('hidden', 'id', $id);
 
         // Setting the form elements

+ 1 - 0
main/inc/lib/extra_field_value.lib.php

@@ -5,6 +5,7 @@ use Chamilo\CoreBundle\Entity\ExtraField as EntityExtraField;
 use Chamilo\CoreBundle\Entity\ExtraFieldRelTag;
 use Chamilo\CoreBundle\Entity\ExtraFieldValues;
 use Chamilo\CoreBundle\Entity\Tag;
+use ChamiloSession as Session;
 
 /**
  * Class ExtraFieldValue

+ 2 - 8
main/inc/lib/pear/HTML/QuickForm/hiddenselect.php

@@ -95,10 +95,7 @@ class HTML_QuickForm_hiddenselect extends HTML_QuickForm_select
         }
 
         return $strHtml;
-    } //end func toHtml
-
-    // }}}
-    // {{{ accept()
+    }
 
    /**
     * This is essentially a hidden element and should be rendered as one
@@ -107,7 +104,4 @@ class HTML_QuickForm_hiddenselect extends HTML_QuickForm_select
     {
         $renderer->renderHidden($this);
     }
-
-    // }}}
-} //end class HTML_QuickForm_hiddenselect
-?>
+}

+ 4 - 14
main/inc/lib/pear/HTML/QuickForm/image.php

@@ -84,10 +84,7 @@ class HTML_QuickForm_image extends HTML_QuickForm_input
     function setBorder($border)
     {
         $this->updateAttributes(array('border' => $border));
-    } // end func setBorder
-
-    // }}}
-    // {{{ setAlign()
+    }
 
     /**
      * Sets alignment for image element
@@ -100,10 +97,7 @@ class HTML_QuickForm_image extends HTML_QuickForm_input
     function setAlign($align)
     {
         $this->updateAttributes(array('align' => $align));
-    } // end func setAlign
-
-    // }}}
-    // {{{ freeze()
+    }
 
     /**
      * Freeze the element so that only its value is returned
@@ -114,9 +108,5 @@ class HTML_QuickForm_image extends HTML_QuickForm_input
     function freeze()
     {
         return false;
-    } //end func freeze
-
-    // }}}
-
-} // end class HTML_QuickForm_image
-?>
+    }
+}

+ 4 - 1
main/lp/lp_ajax_switch_item.php

@@ -237,7 +237,10 @@ function switch_item_details($lp_id, $user_id, $view_id, $current_item, $next_it
         }
 
         // Percentage of the learning paths
-        $pl = $timeLp / $timeTotalCourse;
+        $pl = 0;
+        if (!empty($timeTotalCourse)) {
+            $pl = $timeLp / $timeTotalCourse;
+        }
 
         // Minimum time for each learning path
         $time_total = intval($pl * $tc * $perc / 100) * 60;