Ver Fonte

Minor - Using Security::remove_XSS() + removing unused variables

Julio Montoya há 11 anos atrás
pai
commit
5f55594ffe
2 ficheiros alterados com 10 adições e 13 exclusões
  1. 10 10
      main/admin/access_url_check_user_session.php
  2. 0 3
      main/inc/lib/api.lib.php

+ 10 - 10
main/admin/access_url_check_user_session.php

@@ -32,14 +32,14 @@ $url_id                             = api_get_current_access_url_id();
 $action = $_GET['action'];
 
 switch($action) {
-    case 'add_user_to_url':        
+    case 'add_user_to_url':
         $user_id = $_REQUEST['user_id'];
         $result = UrlManager::add_user_to_url($user_id, $url_id);
         $user_info = api_get_user_info($user_id);
         if ($result) {
             $message = Display::return_message(get_lang('UserAdded').' '.api_get_person_name($user_info['firstname'], $user_info['lastname']), 'confirm');
         }
-        break;    
+        break;
 }
 
 Display::display_header($tool_name);
@@ -67,7 +67,7 @@ if ($show_users_with_problems) {
 foreach($session_list  as $session_item) {
     $session_id = $session_item['id'];
     $html .= '<h3>'.$session_item['name'].'</h3>';
-    
+
     $access_where = "(access_url_id = $url_id OR access_url_id is null )";
     if ($show_users_with_problems) {
         $access_where = "(access_url_id is null)";
@@ -83,24 +83,24 @@ foreach($session_list  as $session_item) {
 
     $result = Database::query($sql);
     $users  = Database::store_result($result);
-    
+
     if (!empty($users)) {
-        $html .= '<table class="data_table"><tr><th>'.get_lang('User').'<th>'.get_lang('Actions').'</th></tr>';   
-    
+        $html .= '<table class="data_table"><tr><th>'.get_lang('User').'<th>'.get_lang('Actions').'</th></tr>';
+
         foreach ($users as $user) {
             $user_link = '';
             if (!empty($user['user_id'])) {
-                $user_link = '<a href="'.api_get_path(WEB_CODE_PATH).'admin/user_information.php?user_id='.intval($user['user_id']).'">'.api_htmlentities(api_get_person_name($user['firstname'], $user['lastname']),ENT_QUOTES,$charset).' ('.$user['username'].')</a>';
+                $user_link = '<a href="'.api_get_path(WEB_CODE_PATH).'admin/user_information.php?user_id='.intval($user['user_id']).'">'.Security::remove_XSS(api_get_person_name($user['firstname'], $user['lastname'])).' ('.$user['username'].')</a>';
             }
 
             $link_to_add_user_in_url = '';
 
             if ($multiple_url_is_on) {
-                if ($user['access_url_id'] != $url_id) {            
+                if ($user['access_url_id'] != $url_id) {
                     $user_link .= ' '.Display::return_icon('warning.png', get_lang('UserNotAddedInURL'), array(), ICON_SIZE_MEDIUM);
-                    $add = Display::return_icon('add.png', get_lang('AddUsersToURL'), array(), ICON_SIZE_MEDIUM);                    
+                    $add = Display::return_icon('add.png', get_lang('AddUsersToURL'), array(), ICON_SIZE_MEDIUM);
                     $link_to_add_user_in_url = '<a href="'.api_get_self().'?'.Security::remove_XSS($_SERVER['QUERY_STRING']).'&action=add_user_to_url&id_session='.$id_session.'&user_id='.$user['user_id'].'">'.$add.'</a>';
-                }                
+                }
             }
             $html .= '<tr>
                     <td>

+ 0 - 3
main/inc/lib/api.lib.php

@@ -1445,7 +1445,6 @@ function api_get_course_setting($setting_name, $course_code = null) {
     if (isset($course_info['settings']) && isset($course_info['settings'][$setting_name])) {
         return $course_info['settings'][$setting_name]['value'];
     } else {
-        //var_dump($course_info);
         $table 		 = Database::get_course_table(TABLE_COURSE_SETTING);
         $setting_name = Database::escape_string($setting_name);
         if (!empty($course_info['real_id']) && !empty($setting_name)) {
@@ -6777,8 +6776,6 @@ function api_get_user_language()
 
 function api_get_language_interface()
 {
-    global $app;
-
     $valid_languages = api_get_languages();
     $user_language = api_get_user_language();