Julio Montoya 5 жил өмнө
parent
commit
71164f4d6f

+ 6 - 2
main/admin/skill_edit.php

@@ -17,16 +17,20 @@ $this_section = SECTION_PLATFORM_ADMIN;
 api_protect_admin_script();
 Skill::isAllowed();
 
-$interbreadcrumb[] = ["url" => 'index.php', "name" => get_lang('PlatformAdmin')];
+$interbreadcrumb[] = ['url' => 'index.php', 'name' => get_lang('PlatformAdmin')];
 $interbreadcrumb[] = ['url' => 'skill_list.php', 'name' => get_lang('ManageSkills')];
 
 /* Process data */
-$skillId = isset($_REQUEST['id']) ? intval($_REQUEST['id']) : 0;
+$skillId = isset($_REQUEST['id']) ? (int) $_REQUEST['id'] : 0;
 
 $objSkill = new Skill();
 $objGradebook = new Gradebook();
 $skillInfo = $objSkill->getSkillInfo($skillId);
 
+if (empty($skillInfo)) {
+    api_not_allowed(true);
+}
+
 $allGradebooks = $objGradebook->find('all');
 
 $skillDefaultInfo = [

+ 2 - 1
main/dropbox/dropbox_download.php

@@ -4,9 +4,10 @@
  * @package chamilo.dropbox
  */
 
-// including the basic Chamilo initialisation file
 require_once __DIR__.'/../inc/global.inc.php';
 
+$_course = api_get_course_info();
+
 // the dropbox file that contains additional functions
 require_once 'dropbox_functions.inc.php';
 

+ 1 - 1
main/inc/lib/skill.lib.php

@@ -2462,8 +2462,8 @@ class Skill extends Model
             $form->addButtonCreate(get_lang('Add'));
         } else {
             $form->addButtonUpdate(get_lang('Update'));
+            $form->addHidden('id', $skillInfo['id']);
         }
-        $form->addHidden('id', null);
 
         return $returnParams;
     }

+ 0 - 3
main/tracking/courseLog.php

@@ -469,9 +469,6 @@ if ($nbStudents > 0) {
         $_GET['users_tracking_per_page'] = 1000000;
     }
 
-    $all_datas = [];
-    $course_code = $_course['id'];
-
     $table = new SortableTableFromArray(
         $usersTracking,
         1,