Browse Source

Minor - format code

Julio 6 years ago
parent
commit
a7513a10e1

+ 1 - 12
main/gradebook/gradebook_view_result.php

@@ -116,13 +116,6 @@ if (isset($_GET['action'])) {
                 );
 
                 $form->addTextarea('comment', get_lang('Comment'));
-
-                /*$form->addRule(
-                    'score',
-                    get_lang('ValueTooBig'),
-                    'max_numeric_length',
-                    $evaluation->get_max()
-                );*/
                 $form->addButtonSave(get_lang('Save'));
                 $attemptList = ResultTable::getResultAttemptTable($result, $url);
                 $form->addLabel(get_lang('Attempts'), $attemptList);
@@ -130,7 +123,6 @@ if (isset($_GET['action'])) {
                 if ($form->validate()) {
                     $values = $form->getSubmitValues();
                     $newScore = $values['score'];
-
                     $newScore = api_number_format(
                         $newScore,
                         api_get_setting('gradebook_number_decimals')
@@ -155,7 +147,6 @@ if (isset($_GET['action'])) {
                 }
 
                 Display::display_header();
-
                 $items[] = [
                     'url' => $backUrl,
                     'content' => Display::return_icon(
@@ -165,7 +156,6 @@ if (isset($_GET['action'])) {
                         ICON_SIZE_MEDIUM
                     ),
                 ];
-
                 echo Display::actions($items);
                 $form->display();
                 Display::display_footer();
@@ -215,7 +205,6 @@ if (isset($_GET['editres'])) {
                 'created_at' => $now,
                 'updated_at' => $now,
             ];
-
             Database::insert($table, $params);
         }
 
@@ -651,7 +640,7 @@ if (!isset($_GET['export']) && (!isset($_GET['import']))) {
         'url' => api_get_path(WEB_CODE_PATH).'gradebook/gradebook_view_result.php?selecteval='.$select_eval.'&'.api_get_cidreq(),
         'name' => get_lang('ViewResult'),
     ];
-    Display :: display_header('');
+    Display::display_header();
 }
 
 if (isset($_GET['adduser'])) {

+ 4 - 9
main/gradebook/lib/fe/displaygradebook.php

@@ -23,7 +23,8 @@ class DisplayGradebook
             $header = '<div class="actions">';
             if ($page != 'statistics') {
                 $header .= '<a href="'.Category::getUrl().'selectcat='.$selectcat.'">'.
-                    Display::return_icon(('back.png'), get_lang('FolderView'), '', ICON_SIZE_MEDIUM).'</a>';
+                    Display::return_icon('back.png', get_lang('FolderView'), '', ICON_SIZE_MEDIUM)
+                    .'</a>';
                 if (($evalobj->get_course_code() != null) && !$evalobj->has_results()) {
                     $header .= '<a href="gradebook_add_result.php?'.api_get_cidreq().'&selectcat='.$selectcat.'&selecteval='.$evalobj->get_id().'">
     				'.Display::return_icon('evaluation_rate.png', get_lang('AddResult'), '', ICON_SIZE_MEDIUM).'</a>';
@@ -45,22 +46,15 @@ class DisplayGradebook
                             Display::return_icon('delete.png', get_lang('DeleteResult'), '', ICON_SIZE_MEDIUM).'</a>';
                     }
                 }
-
                 $header .= '<a href="'.api_get_self().'?'.api_get_cidreq().'&print=&selecteval='.$evalobj->get_id().'" target="_blank">'.
                     Display::return_icon('printer.png', get_lang('Print'), '', ICON_SIZE_MEDIUM).'</a>';
             } else {
                 $header .= '<a href="gradebook_view_result.php?'.api_get_cidreq().'&selecteval='.Security::remove_XSS($_GET['selecteval']).'"> '.
-                    Display::return_icon(('back.png'), get_lang('FolderView'), '', ICON_SIZE_MEDIUM).'</a>';
+                    Display::return_icon('back.png', get_lang('FolderView'), '', ICON_SIZE_MEDIUM).'</a>';
             }
             $header .= '</div>';
         }
 
-        if ($evalobj->is_visible() == '1') {
-            $visible = get_lang('Yes');
-        } else {
-            $visible = get_lang('No');
-        }
-
         $scoredisplay = ScoreDisplay::instance();
         $student_score = '';
         $average = '';
@@ -87,6 +81,7 @@ class DisplayGradebook
                 }
             }
         }
+
         $description = '';
         if (!$evalobj->get_description() == '') {
             $description = get_lang('Description').' :<b> '.$evalobj->get_description().'</b><br>';