Browse Source

Minor - format code

Julio Montoya 5 years ago
parent
commit
f486e49b44

+ 4 - 18
main/admin/access_url_add_courses_to_url.php

@@ -13,7 +13,6 @@ $cidReset = true;
 require_once __DIR__.'/../inc/global.inc.php';
 
 $this_section = SECTION_PLATFORM_ADMIN;
-
 api_protect_global_admin_script();
 
 if (!api_get_multiple_access_url()) {
@@ -21,15 +20,12 @@ if (!api_get_multiple_access_url()) {
     exit;
 }
 
-$form_sent = 0;
 $first_letter_course = '';
 $courses = [];
 $url_list = [];
 $users = [];
 
-$tbl_access_url_rel_course = Database::get_main_table(TABLE_MAIN_ACCESS_URL_REL_COURSE);
 $tbl_access_url = Database::get_main_table(TABLE_MAIN_ACCESS_URL);
-$tbl_user = Database::get_main_table(TABLE_MAIN_USER);
 $tbl_course = Database::get_main_table(TABLE_MAIN_COURSE);
 
 /*	Header   */
@@ -68,29 +64,19 @@ if (isset($_POST['form_sent']) && $_POST['form_sent']) {
     }
 }
 
-if (empty($first_letter_user)) {
-    $sql = "SELECT count(*) as num_courses FROM $tbl_course";
-    $result = Database::query($sql);
-    $num_row = Database::fetch_array($result);
-    if ($num_row['num_courses'] > 1000) {
-        //if there are too much num_courses to gracefully handle with the HTML select list,
-        // assign a default filter on users names
-        $first_letter_user = 'A';
-    }
-    unset($result);
-}
-
 $first_letter_course_lower = Database::escape_string(api_strtolower($first_letter_course));
 
 $sql = "SELECT code, title FROM $tbl_course
-		WHERE title LIKE '".$first_letter_course_lower."%' OR title LIKE '".$first_letter_course_lower."%'
+		WHERE 
+            title LIKE '".$first_letter_course_lower."%' OR 
+		    title LIKE '".$first_letter_course_lower."%'
 		ORDER BY title, code DESC ";
 
 $result = Database::query($sql);
 $db_courses = Database::store_result($result);
 unset($result);
 
-$sql = "SELECT id, url FROM $tbl_access_url  WHERE active=1 ORDER BY url";
+$sql = "SELECT id, url FROM $tbl_access_url WHERE active = 1 ORDER BY url";
 $result = Database::query($sql);
 $db_urls = Database::store_result($result);
 unset($result);

+ 0 - 5
main/admin/access_url_add_usergroup_to_url.php

@@ -20,16 +20,11 @@ if (!api_get_multiple_access_url()) {
 }
 
 $userGroup = new UserGroup();
-$form_sent = 0;
 $firstLetterUserGroup = null;
 $courses = [];
 $url_list = [];
 
-$tbl_access_url_rel_course = Database::get_main_table(TABLE_MAIN_ACCESS_URL_REL_COURSE);
 $tbl_access_url = Database::get_main_table(TABLE_MAIN_ACCESS_URL);
-$tbl_user = Database::get_main_table(TABLE_MAIN_USER);
-$tbl_course = Database::get_main_table(TABLE_MAIN_COURSE);
-
 $tool_name = get_lang('AddUserGroupToURL');
 $interbreadcrumb[] = ['url' => 'index.php', 'name' => get_lang('PlatformAdmin')];
 $interbreadcrumb[] = ['url' => 'access_urls.php', 'name' => get_lang('MultipleAccessURLs')];

+ 0 - 4
main/admin/access_url_add_users_to_url.php

@@ -19,14 +19,10 @@ if (!api_get_multiple_access_url()) {
     exit;
 }
 
-$form_sent = 0;
 $first_letter_user = '';
-$first_letter_course = '';
-$courses = [];
 $url_list = [];
 $users = [];
 
-$tbl_access_url_rel_user = Database::get_main_table(TABLE_MAIN_ACCESS_URL_REL_USER);
 $tbl_access_url = Database::get_main_table(TABLE_MAIN_ACCESS_URL);
 $tbl_user = Database::get_main_table(TABLE_MAIN_USER);
 

+ 0 - 9
main/admin/access_url_edit_courses_to_url.php

@@ -26,11 +26,6 @@ if (!api_get_multiple_access_url()) {
     exit;
 }
 
-// Database Table Definitions
-$tbl_access_url_rel_course = Database::get_main_table(TABLE_MAIN_ACCESS_URL_REL_COURSE);
-$tbl_course = Database::get_main_table(TABLE_MAIN_COURSE);
-$tbl_access_url = Database::get_main_table(TABLE_MAIN_ACCESS_URL);
-
 // setting breadcrumbs
 $tool_name = get_lang('EditCoursesToURL');
 $interbreadcrumb[] = ['url' => 'index.php', 'name' => get_lang('PlatformAdmin')];
@@ -76,10 +71,6 @@ function remove_item(origin) {
 }
 </script>';
 
-$form_sent = 0;
-$UserList = $SessionList = [];
-$users = $sessions = [];
-
 if (isset($_POST['form_sent']) && $_POST['form_sent']) {
     $form_sent = $_POST['form_sent'];
     $course_list = $_POST['course_list'];

+ 1 - 5
main/admin/access_url_edit_usergroup_to_url.php

@@ -71,11 +71,7 @@ function remove_item(origin) {
 }
 </script>';
 
-$form_sent = 0;
 $errorMsg = '';
-$UserList = $SessionList = [];
-$users = $sessions = [];
-
 if (isset($_POST['form_sent']) && $_POST['form_sent']) {
     $form_sent = $_POST['form_sent'];
     $course_list = $_POST['course_list'];
@@ -130,7 +126,7 @@ if ($ajax_search) {
 $link_add_type_unique = ['class' => 'disabled'];
 $link_add_type_multiple = [];
 
-if ($add_type == 'multiple') {
+if ($add_type === 'multiple') {
     $link_add_type_unique = [];
     $link_add_type_multiple = ['class' => 'disabled'];
 }

+ 0 - 5
main/admin/access_url_edit_users_to_url.php

@@ -25,9 +25,6 @@ if (!api_get_multiple_access_url()) {
 
 // Database Table Definitions
 $tbl_user = Database::get_main_table(TABLE_MAIN_USER);
-$tbl_access_url_rel_user = Database::get_main_table(TABLE_MAIN_ACCESS_URL_REL_USER);
-$tbl_access_url = Database::get_main_table(TABLE_MAIN_ACCESS_URL);
-
 // setting breadcrumbs
 $tool_name = get_lang('EditUsersToURL');
 $interbreadcrumb[] = ['url' => 'index.php', 'name' => get_lang('PlatformAdmin')];
@@ -73,9 +70,7 @@ function remove_item(origin) {
 }
 </script>';
 
-$form_sent = 0;
 $errorMsg = '';
-$UserList = [];
 $message = '';
 
 if (isset($_POST['form_sent']) && $_POST['form_sent']) {

+ 2 - 2
main/admin/access_urls.php

@@ -20,7 +20,7 @@ if (!api_get_multiple_access_url()) {
     exit;
 }
 
-$interbreadcrumb[] = ["url" => 'index.php', 'name' => get_lang('PlatformAdmin')];
+$interbreadcrumb[] = ['url' => 'index.php', 'name' => get_lang('PlatformAdmin')];
 $tool_name = get_lang('MultipleAccessURLs');
 Display :: display_header($tool_name);
 
@@ -30,7 +30,7 @@ $url_list = UrlManager::get_url_data();
 
 // Actions
 if (isset($_GET['action'])) {
-    $url_id = (empty($_GET['url_id']) ? 0 : intval($_GET['url_id']));
+    $url_id = empty($_GET['url_id']) ? 0 : (int) $_GET['url_id'];
 
     switch ($_GET['action']) {
         case 'delete_url':

+ 0 - 4
main/admin/add_courses_to_usergroup.php

@@ -47,10 +47,7 @@ function remove_item(origin) {
 
 </script>';
 
-$form_sent = 0;
 $errorMsg = '';
-$sessions = [];
-
 if (isset($_POST['form_sent']) && $_POST['form_sent']) {
     $form_sent = $_POST['form_sent'];
     $elements_posted = $_POST['elements_in_name'];
@@ -301,7 +298,6 @@ unset($sessionUsersList);
 </tr>
 </table>
 </form>
-
 <script>
 function moveItem(origin , destination) {
     for(var i = 0 ; i<origin.options.length ; i++) {

+ 0 - 2
main/admin/add_sessions_to_usergroup.php

@@ -73,9 +73,7 @@ function validate_filter() {
 }
 </script>';
 
-$form_sent = 0;
 $errorMsg = '';
-$sessions = [];
 if (isset($_POST['form_sent']) && $_POST['form_sent']) {
     $form_sent = $_POST['form_sent'];
     $elements_posted = $_POST['elements_in_name'];

+ 1 - 1
main/admin/career_dashboard.php

@@ -37,7 +37,7 @@ $career = new Career();
 $condition = ['status = ?' => 1];
 if ($form->validate()) {
     $data = $form->getSubmitValues();
-    $filter = intval($data['filter']);
+    $filter = (int) $data['filter'];
     if (!empty($filter)) {
         $condition = ['status = ? AND id = ? ' => [1, $filter]];
     }