Browse Source

Removing duplicated code in BBB plugin #1502

Angel Fernando Quiroz Campos 8 years ago
parent
commit
fed51da5cc
2 changed files with 7 additions and 27 deletions
  1. 2 0
      plugin/bbb/admin.tpl
  2. 5 27
      plugin/bbb/lib/bbb.lib.php

+ 2 - 0
plugin/bbb/admin.tpl

@@ -30,6 +30,8 @@
                     {% if meeting.record == 1 %}
                         {# Record list #}
                         {{ meeting.show_links }}
+                    {% else %}
+                        {{ 'NoRecording'|get_lang }}
                     {% endif %}
                 </td>
                 <td>{{ meeting.course ?: '-' }}</td>

+ 5 - 27
plugin/bbb/lib/bbb.lib.php

@@ -722,36 +722,14 @@ class bbb
 
                 $actionLinks = $this->getActionLinks($meetingDB, $record, $isGlobal, $isAdminReport);
                 $item['show_links']  = $recordLink;
-                $item['action_links'] = implode(PHP_EOL, $actionLinks);
-            }else{
-            	$isVisible = $meetingDB['visibility'] != 0;
-            	$linkVisibility = $isVisible
-                    ? Display::url(
-                        Display::return_icon('visible.png', get_lang('MakeInvisible')),
-                        $this->unPublishUrl($meetingDB)
-                    )
-                    : Display::url(
-                        Display::return_icon('invisible.png', get_lang('MakeVisible')),
-                        $this->publishUrl($meetingDB)
-                    );
-                $links = [];
-
-                if (!$isAdminReport) {
-                    $links[] = Display::url(
-                        Display::return_icon('delete.png', get_lang('Delete')),
-                        $this->deleteRecordUrl($meetingDB)
-                    );
-                    $links[] = $linkVisibility;
-                } else {
-                    $links[] = Display::url(
-                        Display::return_icon('course_home.png', get_lang('GoToCourse')),
-                        $this->getListingUrl()
-                    );
-                }
+            } else {
+                $actionLinks = $this->getActionLinks($meetingDB, [], $isGlobal, $isAdminReport);
+
                 $item['show_links'] = get_lang('NoRecording');
-                $item['action_links'] = implode(PHP_EOL, $links);
             }
 
+            $item['action_links'] = implode(PHP_EOL, $actionLinks);
+
             $item['created_at'] = api_convert_and_format_date($meetingDB['created_at']);
             // created_at
             $meetingDB['created_at'] = $item['created_at']; //avoid overwrite in array_merge() below