Эх сурвалжийг харах

[Tests] Fix Twitter wrong exception raises + test param twitter + wakeonlan neuron test on params

monf 8 жил өмнө
parent
commit
b8a0d1c999

+ 3 - 3
neurons/twitter/tests/test_twitter_neuron.py

@@ -1,6 +1,6 @@
 import unittest
 
-from core.NeuronModule import InvalidParameterException
+from core.NeuronModule import MissingParameterException
 from neurons.twitter.twitter import Twitter
 
 
@@ -15,7 +15,7 @@ class TestTwitter(unittest.TestCase):
 
     def testParameters(self):
         def run_test(parameters_to_test):
-            with self.assertRaises(InvalidParameterException):
+            with self.assertRaises(MissingParameterException):
                 Twitter(**parameters_to_test)
 
         # empty
@@ -65,4 +65,4 @@ class TestTwitter(unittest.TestCase):
             "access_token_key": self.access_token_key,
             "tweet": self.tweet
         }
-        run_test(parameters)
+        run_test(parameters)

+ 6 - 6
neurons/twitter/twitter.py

@@ -1,6 +1,6 @@
 import twitter
 
-from core.NeuronModule import NeuronModule, InvalidParameterException
+from core.NeuronModule import NeuronModule, InvalidParameterException, MissingParameterException
 
 
 class Twitter(NeuronModule):
@@ -36,15 +36,15 @@ class Twitter(NeuronModule):
         .. raises:: InvalidParameterException
         """
         if self.consumer_key is None:
-            raise InvalidParameterException("Twitter needs a consumer_key")
+            raise MissingParameterException("Twitter needs a consumer_key")
         if self.consumer_secret is None:
-            raise InvalidParameterException("Twitter needs a consumer_secret")
+            raise MissingParameterException("Twitter needs a consumer_secret")
         if self.access_token_key is None:
-            raise InvalidParameterException("Twitter needs an access_token_key")
+            raise MissingParameterException("Twitter needs an access_token_key")
         if self.access_token_secret is None:
-            raise InvalidParameterException("Twitter needs and access_token_secret")
+            raise MissingParameterException("Twitter needs and access_token_secret")
         if self.tweet is None:
-            raise InvalidParameterException("You need to provide something to tweet !")
+            raise MissingParameterException("You need to provide something to tweet !")
 
         return True
 

+ 0 - 0
neurons/wake_on_lan/tests/__init__.py


+ 67 - 0
neurons/wake_on_lan/tests/test_wake_on_lan.py

@@ -0,0 +1,67 @@
+import unittest
+import ipaddress
+
+from core.NeuronModule import InvalidParameterException, MissingParameterException
+from neurons.wake_on_lan.wake_on_lan import Wake_on_lan
+
+
+class TestWakeOnLan(unittest.TestCase):
+
+    def setUp(self):
+        self.mac_address="00:0a:95:9d:68:16"
+        self.broadcast_address = "255.255.255.255"
+        self.port = 42
+
+    def testParameters(self):
+        def run_test_invalidParam(parameters_to_test):
+            with self.assertRaises(InvalidParameterException):
+                Wake_on_lan(**parameters_to_test)
+
+        def run_test_missingParam(parameters_to_test):
+            with self.assertRaises(MissingParameterException):
+                Wake_on_lan(**parameters_to_test)
+
+        def run_test_valueError(parameters_to_test):
+            with self.assertRaises(ValueError):
+                Wake_on_lan(**parameters_to_test)
+
+        # empty
+        parameters = dict()
+        run_test_missingParam(parameters)
+
+        # missing mac_address
+        parameters = {
+            "broadcast_address": self.broadcast_address,
+            "port": self.port
+        }
+        run_test_missingParam(parameters)
+
+        # port is not an int
+        self.port = "port"
+        parameters = {
+            "broadcast_address": self.broadcast_address,
+            "mac_address": self.mac_address,
+            "port": self.port
+        }
+        run_test_invalidParam(parameters)
+        self.port = 42
+
+        # is broadcast not a valid format
+        self.broadcast_address = "broadcast"
+        parameters = {
+            "broadcast_address": self.broadcast_address,
+            "mac_address": self.mac_address,
+            "port": self.port
+        }
+        run_test_valueError(parameters)
+        self.broadcast_address = "255.255.255.255"
+
+        # is mac_address not a valid IPv4 or IPv6 format
+        self.mac_address = "mac_address"
+        parameters = {
+            "broadcast_address": self.broadcast_address,
+            "mac_address": self.mac_address,
+            "port": self.port
+        }
+        run_test_valueError(parameters)
+        self.mac_address = "00:0a:95:9d:68:16"